feat: add basic-auth UI Form #1718

LiteSun · 2021-04-08T08:27:06Z

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

Bugfix
New feature provided
Improve performance
Backport patches

What changes will this PR take into?
add basic-auth UI Form.

Checklist:

Did you explain what problem does this PR solve? Or what new features have been added?
Have you added corresponding test cases?
Have you modified the corresponding document?
Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

codecov-io · 2021-04-08T11:19:43Z

Codecov Report

Merging #1718 (0755b95) into master (2c158a1) will decrease coverage by 19.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1718       +/-   ##
===========================================
- Coverage   72.08%   52.25%   -19.83%     
===========================================
  Files         130       38       -92     
  Lines        5649     2660     -2989     
  Branches      648        0      -648     
===========================================
- Hits         4072     1390     -2682     
+ Misses       1333     1082      -251     
+ Partials      244      188       -56

Flag	Coverage Δ
backend-e2e-test	`?`
backend-e2e-test-ginkgo	`?`
backend-unit-test	`52.25% <ø> (-0.04%)`	⬇️
frontend-e2e-test	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/internal/utils/version.go	`0.00% <0.00%> (-100.00%)`	⬇️
api/internal/filter/request_id.go	`0.00% <0.00%> (-100.00%)`	⬇️
api/internal/core/entity/entity.go	`0.00% <0.00%> (-100.00%)`	⬇️
api/internal/core/store/storehub.go	`0.00% <0.00%> (-71.03%)`	⬇️
api/internal/filter/cors.go	`0.00% <0.00%> (-66.67%)`	⬇️
api/internal/filter/schema.go	`0.00% <0.00%> (-55.47%)`	⬇️
api/internal/utils/consts/api_error.go	`0.00% <0.00%> (-50.00%)`	⬇️
api/internal/handler/data_loader/route_import.go	`27.41% <0.00%> (-37.50%)`	⬇️
api/internal/handler/handler.go	`42.59% <0.00%> (-35.19%)`	⬇️
api/internal/handler/schema/schema.go	`66.66% <0.00%> (-33.34%)`	⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c158a1...0755b95. Read the comment docs.

web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js

web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js

web/src/components/Plugin/PluginDetail.tsx

juzhiyuan · 2021-04-08T14:22:58Z

please update the codes styles.

web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js

web/src/components/Plugin/UI/basic-auth.tsx

juzhiyuan · 2021-04-09T01:20:18Z

Good to see i18n

moonming · 2021-04-09T01:53:41Z

Is there a preview page?

web/src/components/Plugin/UI/basic-auth.tsx

LiteSun · 2021-04-09T02:15:59Z

Is there a preview page?

Currently, each pr does not have a preview address, it needs to be pulled locally to preview.

liuxiran · 2021-04-09T02:43:40Z

Is there a preview page?

Currently, each pr does not have a preview address, it needs to be pulled locally to preview.

may be provide a video also a good choice, which can explain the changes on the UE more clearly

imjoey

/lgtm

Noted here that the empty list item reflects null instead of `` should be eliminated.

LiteSun · 2021-04-09T03:42:31Z

/lgtm

Noted here that the empty list item reflects null instead of `` should be eliminated.

Thanks for the note, will keep this in mind when dealing with plugins that have list item.

juzhiyuan · 2021-04-09T04:01:23Z

web/cypress/fixtures/selector.json

+  "pageTwoActived": ".ant-pagination-item-2.ant-pagination-item-active",
+  "selectDropdown": ".ant-select-dropdown",
+  "codeMirrorMode": "[data-cy='code-mirror-mode']",
+  "selectJSON":".ant-select-dropdown [label=JSON]"


Suggested change

"selectJSON":".ant-select-dropdown [label=JSON]"

"selectJSON": ".ant-select-dropdown [label=JSON]"

ok, will be adjusted in another PR.

jbampton · 2021-04-09T03:53:21Z

web/src/components/Plugin/UI/plugin.tsx

+
+export const PLUGIN_UI_LIST = ['basic-auth',];
+
+export const PluginForm: React.FC<Props> = ({ name, renderForm, form }) => {


I started learning .tsx today so I still don't know much. But maybe const line should have ordered arguments ?

Suggested change

export const PluginForm: React.FC<Props> = ({ name, renderForm, form }) => {

export const PluginForm: React.FC<Props> = ({ form, name, renderForm }) => {

We are passing in objects, the order of the arguments does not affect the function's functionality IMO, any reference about this rule?

jbampton · 2021-04-09T03:56:32Z

web/src/components/Plugin/UI/plugin.tsx

+
+import BasicAuth from './basic-auth'
+
+type Props = {


Does this order work for .tsx?

Suggested change

type Props = {

type Props = {

form: FormInstance,

name: string,

renderForm: boolean

}

jbampton · 2021-04-09T03:59:33Z

web/src/components/Plugin/PluginDetail.tsx

          ]}
        />
-        <CodeMirror
+        {Boolean(codeMirrorMode === codeMirrorModeList.UIForm) && <PluginForm name={name} form={UIForm} renderForm={!(pluginType === 'auth' && schemaType !== 'consumer')} />}


Should this be form, name, renderForm ?

Suggested change

{Boolean(codeMirrorMode === codeMirrorModeList.UIForm) && <PluginForm name={name} form={UIForm} renderForm={!(pluginType === 'auth' && schemaType !== 'consumer')} />}

{Boolean(codeMirrorMode === codeMirrorModeList.UIForm) && <PluginForm form={UIForm} name={name} renderForm={!(pluginType === 'auth' && schemaType !== 'consumer')} />}

jbampton · 2021-04-09T04:01:24Z

web/src/components/Plugin/PluginDetail.tsx

+          const { data: yamlData, error } = yaml2json(ref.current.editor.getValue(), true);
+          if (error) {
+            notification.error({
+              message: 'Invalid Yaml data',


Suggested change

message: 'Invalid Yaml data',

message: 'Invalid YAML data',

juzhiyuan · 2021-04-09T04:41:33Z

@jbampton Hi, I just noticed your suggestions :) Could you please file a new PR? due to this change will trigger CI many times 🤣

LiteSun added 7 commits April 8, 2021 16:25

feat: add basic-auth UI Form

dd807d3

feat: update

62619d7

fix: pluginTemplate CI

7e92854

feat: update route ci

d56d310

feat: update service ci

5c2f081

fix: plugin ci

132dcf4

fix: fe ci

59dba3e

LiteSun marked this pull request as ready for review April 8, 2021 10:23

LiteSun requested review from juzhiyuan, liuxiran, bzp2010 and Jaycean April 8, 2021 10:24

LiteSun force-pushed the basic-auth-ui branch from b9c89ae to 59dba3e Compare April 8, 2021 10:45

feat: update

0eacc8b

juzhiyuan approved these changes Apr 8, 2021

View reviewed changes

chore: format codes

9295fbc

liuxiran reviewed Apr 8, 2021

View reviewed changes

web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js Outdated Show resolved Hide resolved

liuxiran reviewed Apr 8, 2021

View reviewed changes

web/src/components/Plugin/UI/basic-auth.tsx Show resolved Hide resolved

feat: show empty when no configuration is required

ee2dfb7

feat: update ci

23fb278

membphis reviewed Apr 9, 2021

View reviewed changes

web/src/components/Plugin/UI/basic-auth.tsx Show resolved Hide resolved

LiteSun mentioned this pull request Apr 9, 2021

Provide better field, field descriptions for UIForm #1724

Open

3 tasks

liuxiran approved these changes Apr 9, 2021

View reviewed changes

imjoey approved these changes Apr 9, 2021

View reviewed changes

LiteSun added 3 commits April 9, 2021 11:22

feat: update

0755b95

feat: update

b94ac34

fix: lint

f502816

juzhiyuan approved these changes Apr 9, 2021

View reviewed changes

jbampton reviewed Apr 9, 2021

View reviewed changes

LiteSun requested review from nic-chen and Yiyiyimu April 9, 2021 04:26

Yiyiyimu approved these changes Apr 9, 2021

View reviewed changes

LiteSun merged commit 82ab89e into apache:master Apr 9, 2021

LiteSun deleted the basic-auth-ui branch April 9, 2021 04:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add basic-auth UI Form #1718

feat: add basic-auth UI Form #1718

LiteSun commented Apr 8, 2021 •

edited

Loading

codecov-io commented Apr 8, 2021 •

edited

Loading

juzhiyuan commented Apr 8, 2021

juzhiyuan commented Apr 9, 2021

moonming commented Apr 9, 2021

LiteSun commented Apr 9, 2021

liuxiran commented Apr 9, 2021

imjoey left a comment

LiteSun commented Apr 9, 2021

juzhiyuan Apr 9, 2021

LiteSun Apr 9, 2021

jbampton Apr 9, 2021

LiteSun Apr 9, 2021

jbampton Apr 9, 2021

jbampton Apr 9, 2021

jbampton Apr 9, 2021

juzhiyuan commented Apr 9, 2021

	"selectJSON":".ant-select-dropdown [label=JSON]"
	"selectJSON": ".ant-select-dropdown [label=JSON]"


		export const PLUGIN_UI_LIST = ['basic-auth',];

		export const PluginForm: React.FC<Props> = ({ name, renderForm, form }) => {

-type Props = {
+type Props = {
+  form: FormInstance,
+  name: string,
+  renderForm: boolean
+}

	{Boolean(codeMirrorMode === codeMirrorModeList.UIForm) && <PluginForm name={name} form={UIForm} renderForm={!(pluginType === 'auth' && schemaType !== 'consumer')} />}
	{Boolean(codeMirrorMode === codeMirrorModeList.UIForm) && <PluginForm form={UIForm} name={name} renderForm={!(pluginType === 'auth' && schemaType !== 'consumer')} />}

feat: add basic-auth UI Form #1718

feat: add basic-auth UI Form #1718

Conversation

LiteSun commented Apr 8, 2021 • edited Loading

codecov-io commented Apr 8, 2021 • edited Loading

Codecov Report

juzhiyuan commented Apr 8, 2021

juzhiyuan commented Apr 9, 2021

moonming commented Apr 9, 2021

LiteSun commented Apr 9, 2021

liuxiran commented Apr 9, 2021

imjoey left a comment

Choose a reason for hiding this comment

LiteSun commented Apr 9, 2021

juzhiyuan Apr 9, 2021

Choose a reason for hiding this comment

LiteSun Apr 9, 2021

Choose a reason for hiding this comment

jbampton Apr 9, 2021

Choose a reason for hiding this comment

LiteSun Apr 9, 2021

Choose a reason for hiding this comment

jbampton Apr 9, 2021

Choose a reason for hiding this comment

jbampton Apr 9, 2021

Choose a reason for hiding this comment

jbampton Apr 9, 2021

Choose a reason for hiding this comment

juzhiyuan commented Apr 9, 2021

LiteSun commented Apr 8, 2021 •

edited

Loading

codecov-io commented Apr 8, 2021 •

edited

Loading