fix: inconsistent displayname of updatetime under EN locale #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
ericsyh
changed the title
juzhiyuan
approved these changes
Apr 10, 2021
|
@juzhiyuan Any command to trigger the test again? The backend e2e CI failed .... |
|
@ericsyh luarocks.org is unstable today, please be patient. We will help you to trigger it once it's back. |
I see. |
nic-chen
approved these changes
Apr 12, 2021
|
@ericsyh please sync code from branch master to pass backend e2e test. |
|
Deploy preview for apisix-dashboard ready! Built with commit 405f3cc |
starsz
approved these changes
Apr 14, 2021
|
@ericsyh Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Shen ericshenyuhao@outlook.com
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
There is an in inconsistent display name on the Route, Upstream and SSL pages:
So i modified
component.global.updateTimeandpage.upstream.list.edit.timeto keep the display name align as Update Time.Related issues
No related issue.
Checklist: