Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support auto build rpm package for dashboard #1766

Merged
merged 7 commits into from
Apr 17, 2021

Conversation

nic-chen
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

support auto build rpm package for dashboard

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for apisix-dashboard ready!

Built with commit a8e4a72

https://deploy-preview-1766--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member

please request reviews


- name: Build rpm package
run: |
export VERSION=2.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard code ?


- name: Install rpm package
run: |
export VERSION=2.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard code ?

- name: Run test cases
run: |
ls -l
pwd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug lines?

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.83%. Comparing base (f1b8f0c) to head (a8e4a72).
Report is 380 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
- Coverage   72.12%   71.83%   -0.30%     
==========================================
  Files         125      172      +47     
  Lines        2906     6035    +3129     
  Branches      699      699              
==========================================
+ Hits         2096     4335    +2239     
- Misses        810     1456     +646     
- Partials        0      244     +244     
Flag Coverage Δ
backend-e2e-test 46.97% <ø> (?)
backend-e2e-test-ginkgo 49.15% <ø> (?)
backend-unit-test 52.27% <ø> (?)
frontend-e2e-test 72.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nic-chen nic-chen merged commit 17ff973 into apache:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants