-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing label in nodes component #1823
Conversation
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
Deploy preview for apisix-dashboard ready! Built with commit cfaee0c |
Codecov Report
@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
+ Coverage 71.73% 71.98% +0.24%
==========================================
Files 172 125 -47
Lines 6100 2948 -3152
Branches 713 713
==========================================
- Hits 4376 2122 -2254
+ Misses 1480 826 -654
+ Partials 244 0 -244
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
On the Upstream create page, host label is missing.
So i add the label of host on the page, it will look like:
Related issues
No related issue.
Checklist: