Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing label in nodes component #1823

Merged
merged 2 commits into from
Apr 25, 2021

Conversation

ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Apr 23, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

On the Upstream create page, host label is missing.

So i add the label of host on the page, it will look like:

Related issues

No related issue.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

ericsyh added 2 commits April 24, 2021 00:47
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
@netlify
Copy link

netlify bot commented Apr 23, 2021

Deploy preview for apisix-dashboard ready!

Built with commit cfaee0c

https://deploy-preview-1823--apisix-dashboard.netlify.app

@ericsyh ericsyh changed the title Fix: add missing label in nodes component fix: add missing label in nodes component Apr 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1823 (cfaee0c) into master (a45ba91) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   71.73%   71.98%   +0.24%     
==========================================
  Files         172      125      -47     
  Lines        6100     2948    -3152     
  Branches      713      713              
==========================================
- Hits         4376     2122    -2254     
+ Misses       1480      826     -654     
+ Partials      244        0     -244     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 71.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Upstream/components/Nodes.tsx 100.00% <ø> (ø)
api/internal/handler/route/route.go
api/internal/core/storage/etcd.go
api/internal/core/store/validate_mock.go
...l/handler/route_online_debug/route_online_debug.go
api/internal/filter/recover.go
api/internal/handler/consumer/consumer.go
api/internal/filter/request_id.go
api/internal/filter/schema.go
api/internal/utils/pid.go
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45ba91...cfaee0c. Read the comment docs.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit 2f3717f into apache:master Apr 25, 2021
@ericsyh ericsyh deleted the nodes-missing-label branch April 26, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants