-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate an uid when post a route without id #1883
Conversation
Deploy preview for apisix-dashboard ready! Built with commit 8e97cf3 |
Codecov Report
@@ Coverage Diff @@
## master #1883 +/- ##
==========================================
- Coverage 72.10% 66.54% -5.57%
==========================================
Files 125 173 +48
Lines 2947 6208 +3261
Branches 711 712 +1
==========================================
+ Hits 2125 4131 +2006
- Misses 822 1755 +933
- Partials 0 322 +322
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -23,6 +23,7 @@ import ( | |||
"github.com/onsi/ginkgo" | |||
"github.com/onsi/ginkgo/extensions/table" | |||
"github.com/onsi/gomega" | |||
"github.com/tidwall/gjson" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this file seems doesn't test script
field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request body was contained in dag-conf.json.Also include the script
field.
You can see this file line 32.
bytes, err := ioutil.ReadFile("../../testdata/dag-conf.json")
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
This PR is to fix this situation:
when creating the route with the script, but without the id.The original logic will return the
key is required
.What changes will this PR take into?
Fix the situation:
When creating the route with the script, but without the id.The original logic will return the
key is required
.Checklist: