-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logger on Windows #1947
fix: logger on Windows #1947
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: d947510 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60d19a2748e6f40008049ec4 😎 Browse the preview: https://deploy-preview-1947--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
- Coverage 66.91% 63.95% -2.97%
==========================================
Files 179 122 -57
Lines 6537 3154 -3383
Branches 753 753
==========================================
- Hits 4374 2017 -2357
+ Misses 1897 1137 -760
+ Partials 266 0 -266
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test manually to confirm that there is no problem, since CI does not support Windows currently.
I found that when I remove the code in
|
1c86e75
to
d947510
Compare
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
The following errors will appear when the current Manager API is running on windows.
uber-go/zap
can't directly handle the windows path starting with, for example,C:\
. This PR adds a new scheme processor, which supports accessing log files on Windows system by usingwinfile:///C:\
. At the same time, the program will automatically addwinfile
when generating the absolute path on Windows.Checklist: