-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set a initial weight value for the upstream node #1979
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: adba408 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60edc4732a3ffc000743a328 😎 Browse the preview: https://deploy-preview-1979--apisix-dashboard.netlify.app |
@okaybase I don't think its the need right now, also doing break change to code directly will ruin the tests also |
Thanks for your review firstly. @iamayushdas |
I'm not sure if this will take a break change for users 🤔 need @liuxiran and @nic-chen to confirm. |
If it fill in the default value automatically when weight is empty, I think it's ok. |
Okay then |
so should we allow the default value 1? @nic-chen |
1 is OK. It’s just that if the weight is filled in by default, users may forget to change it in by themselves. I also hesitate about this. |
I want to make sure that when there is only one node in the upstream, the value of the weight is of little significance right @nic-chen , and when there are several nodes in the upstream, the user would be an advanced user IMO, he/she would know how to set the wight. So set default value for weight is good for me. |
Thanks for your review firstly. @juzhiyuan @nic-chen @liuxiran In a production environment, the number of upstream nodes is usually large in order to solve single-point problems and handle large request traffic. |
Thanks for your approval. @juzhiyuan @iamayushdas |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
For most scenarios, the weight value of the upstream node is 1, so setting a initial weight value 1 can reduce user input.
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve
Checklist: