-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(route): add operators #2022
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 48591b9 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/610d3817fcbfd0000735b7de 😎 Browse the preview: https://deploy-preview-2022--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
+ Coverage 63.52% 63.96% +0.44%
==========================================
Files 121 121
Lines 3213 3194 -19
Branches 779 773 -6
==========================================
+ Hits 2041 2043 +2
+ Misses 1172 1151 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't modify unchanged codes.
Co-authored-by: liuxiran <liuxiran@apache.org>
It would be better to add a test case to verify whether we have covered add the operators |
I am supplementing the test part |
LGTM! cc @liuxiran @iamayushdas please have a look |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
support all operators in route vars field .
Related issues
fix #2014
Checklist: