Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add redis-cluster policy tips for limit-count #2058

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 11, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Related issues

fix/resolve:
add redis-cluster policy tips for limit-count

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: f99d151

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6115c66cb273a800083540d7

😎 Browse the preview: https://deploy-preview-2058--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #2058 (b4a18e1) into master (e8503a0) will decrease coverage by 0.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
- Coverage   66.11%   65.14%   -0.97%     
==========================================
  Files         121       60      -61     
  Lines        3226     3779     +553     
  Branches      787        0     -787     
==========================================
+ Hits         2133     2462     +329     
+ Misses       1093     1033      -60     
- Partials        0      284     +284     
Flag Coverage Δ
backend-e2e-test 47.34% <0.00%> (?)
backend-unit-test 52.98% <ø> (?)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/migrate/dataset.go 0.00% <0.00%> (ø)
...components/passive-check/Unhealthy/TcpFailures.tsx
...components/PluginFlow/components/Toolbar/index.tsx
...es/Route/components/DebugViews/DebugParamsView.tsx
...omponents/Upstream/components/UpstreamSelector.tsx
web/src/components/Plugin/UI/limit-count.tsx
...ents/Upstream/components/active-check/HttpPath.tsx
web/src/components/RawDataEditor/RawDataEditor.tsx
web/src/pages/Service/service.ts
...s/Upstream/components/active-check/Concurrency.tsx
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8503a0...b4a18e1. Read the comment docs.

@LiteSun LiteSun merged commit 393b2bf into apache:master Aug 23, 2021
@okaybase okaybase deleted the tips branch August 23, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants