Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve codes style & bug fix #579

Merged
merged 15 commits into from
Oct 22, 2020
Merged

feat: improve codes style & bug fix #579

merged 15 commits into from
Oct 22, 2020

Conversation

juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented Oct 21, 2020

  • Update Request intercepters
  • remove unused codes
  • fix plugin
  • hide SSL module

resolve #527

@juzhiyuan juzhiyuan marked this pull request as draft October 21, 2020 08:40
@juzhiyuan juzhiyuan added this to the 2.0 milestone Oct 22, 2020
@juzhiyuan juzhiyuan marked this pull request as ready for review October 22, 2020 04:30
Copy link
Member

@LiteSun LiteSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liuxiran
Copy link
Contributor

may I ask why hide ssl module?

@juzhiyuan
Copy link
Member Author

may I ask why hide ssl module?

Because there has one API which doesn't support PATCH SSL (enable or disable)

@juzhiyuan
Copy link
Member Author

may I ask why hide ssl module?

SSL module will be updated and enabled in the 2.1 milestone.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit e9d5040 into master Oct 22, 2020
@juzhiyuan juzhiyuan deleted the feat-improvement branch October 22, 2020 05:06
@liuxiran
Copy link
Contributor

SSL module will be updated and enabled in the 2.1 milestone.

Ok, thx

LiteSun added a commit to LiteSun/incubator-apisix-dashboard that referenced this pull request Oct 26, 2020
* fix: lose focus when input in route step1 (apache#582)

* feat: improve codes style & bug fix (apache#579)

* feat: use svg locally

* feat(Route): use id as rowkey

* feat: update global request

* feat: update import order

* feat: remove unused rules

* fix(Route): PluginOrchestration

* feat(request): using code instead of status code

* feat: remove comments

* feat(i18n): consumer

* feat(SSL): hide SSL currently

* feat(Login): using errorHandler

* feat: update version

* feat: update version

* feat: update plugin's version

Co-authored-by: litesun <7sunmiao@gmail.com>

* feat(CI): create NewCI for embedding static files into Go binaries (apache#583)

Co-authored-by: bzp2010 <baizp@iydhp.com>

* fix: add custom checking for resource's conf (apache#584)

* fix: add custom checking for resource's conf

* fix: add custom checking for resource's conf

* test: add test cases

* test: add test case

* test: add test cases via handler

* fix: remove debug log

* fix: check whether it is nil before using the variable (apache#589)

* chore: deployment update and remove all  files related to MySQL (apache#581)

* update build/run and README

* feat: update dockerfile and compose

* chore: update README

* fix: CI failed

* chore: change go version

* fix doc style

* fix run error

* fix: update README about ETCD

* fix: list item desc not showing (apache#591)

* feat: docs improvment (apache#592)

* feat: update action's name

* feat: update action's name

* feat: remove unused files

* feat: update template's typo

* feat: update PR template

* feat: prettier lint

* feat(docs): added USER_GUIDE in Chinese

* feat(docs): update user guide

* feat(docs): added some features

* feat: added changelog in Chinese

* feat(docs): added License

* feat(docs): update README

* feat(docs): update typo

* feat(docs): remove tip

* feat(docs): adjust files folder

* feat(docs): adjust files folder

* feat(docs): remove extra space

* feat: update action's name

* feat(doc): update some incompatible cases

* feat(docs): added sh flag

* Update deploy.zh-CN.md

* feat(SSL): added SSL (apache#596)

* feat(SSL): added SSL

* feat: added sni search

* feat: update i18n

* feat: add file server (apache#594)

* feat: add file server

* dock: add descrition for file server

* doc: update docs about preinstall in deployment (apache#597)

* fix: update docs about preinstall in deployment

* fix: use the exists schema.json so we don't need Lua on building

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

* feat: added frontend login test e2e

Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: bzp2010 <bzp20000818@gmail.com>
Co-authored-by: bzp2010 <baizp@iydhp.com>
Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com>
Co-authored-by: Vinci Xu <277040271@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wolf-rbac can't add to plugin page
3 participants