Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implmement sub-command like stop, restart for manager-api #741

Closed
1 of 5 tasks
tokers opened this issue Nov 9, 2020 · 7 comments · Fixed by #1333
Closed
1 of 5 tasks

Implmement sub-command like stop, restart for manager-api #741

tokers opened this issue Nov 9, 2020 · 7 comments · Fixed by #1333
Assignees
@tokers
Labels
backend discuss enhancement New feature or request
Milestone
2.4

Comments

@tokers
Copy link
Contributor

tokers commented Nov 9, 2020

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirements
  • Feature or performance improvement
  • Other

Requirements or improvement.

Currently the restart of manage-api is manual, 。i.e. kill the process firstly, that's not so convenient, we can implement some sub command like ./manager-api stop and ./manager-api restart and etc (after #739 is solved).
@membphis
Copy link
Member

membphis commented Nov 9, 2020

how to find the old pid? local file? like nginx.pid?

@tokers
Copy link
Contributor Author

tokers commented Nov 10, 2020

how to find the old pid? local file? like nginx.pid?

Yep.

@juzhiyuan juzhiyuan added the wait for update 1. Solution 2. Due date 3. Assignees if needed label Nov 24, 2020
@juzhiyuan
Copy link
Member

any update?

@tokers
Copy link
Contributor Author

tokers commented Dec 22, 2020

It seems the priority of this feature is not so high, so what about postponing it to a future milestone?

@juzhiyuan juzhiyuan removed the wait for update 1. Solution 2. Due date 3. Assignees if needed label Dec 22, 2020
@juzhiyuan
Copy link
Member

good to me 😄

@juzhiyuan juzhiyuan added the enhancement New feature or request label Dec 22, 2020
@juzhiyuan
Copy link
Member

in 2.4 or 2.5?

@tokers
Copy link
Contributor Author

tokers commented Jan 4, 2021

I think 2.4 is appropriate.

@juzhiyuan juzhiyuan added this to the 2.4 milestone Jan 4, 2021
@tokers tokers mentioned this issue Jan 19, 2021
Merged
4 tasks
starsz pushed a commit that referenced this issue Jan 25, 2021
@tokers
chore: add stop subcommand (#741)
39aac5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tokers tokers

Labels
backend discuss enhancement New feature or request
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

chore: add stop subcommand tokers/apisix-dashboard
3 participants
@juzhiyuan @membphis @tokers