feat: support etcd username&&password #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiqizjl
changed the title
|
Good job. Need test case for it. Thanks. |
|
I think we could add test cases in: and verify auth config like: |
juzhiyuan
reviewed
Nov 17, 2020
| @@ -22,6 +22,8 @@ conf: | |||
| etcd: | |||
| endpoints: # supports defining multiple etcd host addresses for an etcd cluster | |||
| - 127.0.0.1:2379 | |||
| username: "" | |||
There was a problem hiding this comment.
if we use an empty string here, does it mean we could connect ETCD anonymously?
There was a problem hiding this comment.
Yes. When the string is empty, it can be linked anonymously
|
@qiqizjl please add test case |
|
gentle ping @qiqizjl |
juzhiyuan
added
the
wait for update
|
@qiqizjl any news? |
|
Trying to add test case |
juzhiyuan
added
backend
enhancement
|
Will this close #839? |
|
@qiqizjl any news? ^_^ |
|
we have support this feature by other PR #951 . closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Related issues
Bugfix
support ETCD username password
New feature or improvement