-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add consumer test ( E2E ) #880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 43.10% 43.10%
=======================================
Files 18 18
Lines 1290 1290
=======================================
Hits 556 556
Misses 642 642
Partials 92 92 Continue to review full report at Codecov.
|
} | ||
} | ||
|
||
func TestConsumer_with_createtime_updatetime(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the testing framework? Is this test related to the title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is used to test when the consumer is updated, it's create_time should not be updated and update_time should be updated. The current framework does not support obtaining update_time and create_time from the response, so I use standard library
and assert
to achieve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @moonming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @moonming Can you review it when you have time?
@idbeta CI failed: https://github.com/apache/apisix-dashboard/pull/880/checks?check_run_id=1483626371#step:5:85 it should be a bug.
|
|
LGTM |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
E2E test
Related issues