test: e2e test chash upstream with key (remote_addr) #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
==========================================
- Coverage 43.10% 43.02% -0.08%
==========================================
Files 18 18
Lines 1290 1290
==========================================
- Hits 556 555 -1
- Misses 642 643 +1
Partials 92 92
Continue to review full report at Codecov.
|
membphis
requested changes
Nov 27, 2020
nic-chen
reviewed
Nov 29, 2020
idbeta
changed the title
membphis
changed the title
membphis
requested changes
Dec 1, 2020
api/test/e2e/upstream_test.go
Outdated
| } | ||
| resp.Body.Close() | ||
| } | ||
| assert.Equal(t, 18, res["1980"]+res["1981"]+res["1982"]) |
There was a problem hiding this comment.
this way is meanless.
I think we can write more comments here or we change to a different way.
membphis
approved these changes
Dec 2, 2020
|
@nic-chen @moonming @gxthrj @ShiningRush please review this PR if you have time |
|
LGTM Except for some code format issues. |
nic-chen
reviewed
Dec 2, 2020
nic-chen
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
E2E test
New feature provided
Improve performance
Related issues
related issue: enhance e2e test for upstream #908