fix: gateway ssl config indentation #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for TLS (SSL) configuration was added in this PR, but it seems that indentation of ssl stanza is incorrect, since changing some values does take effect, e.g. changing port from 9443 to 443.
Port is changed in configMap, also in container definition, but internally,
nginx.confis still rendered with port 9443.According to this line, configuration is extracted from YAML file at
apisix.ssl.listen, not atssl.listen.If is I manually re-write the configMap and move the section then the port is changed as expected.