Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options for standalone configuration #717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jompu
Copy link

@jompu jompu commented Feb 2, 2024

Related to issue: #705

Allow to set standalone configuration with chart values or by using existing ConfigMap.

type: roundrobin
# -- Specifies the name of the ConfigMap that contains the rule configurations.
# The configuration must be set to the key named `apisix.yaml` in the configmap.
existingConfigMap: ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for this subchart issue: #705

Though I have not tested if this is really needed for that use case. But I think there are many reasons that some one would like to use a configmap that is created outside of this chart. For example related to devops automation, where the configuration is defined/updated separate to the chart installation.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this as well. The current Helm chart adds a apisix.yaml ConfigMap when it is installed in standalone mode. This ConfigMap contains a /hi route that is impossible to modify or remove. We need the ability to specify our own rule config instead of this example config.

One workaround would maybe be to "overwrite" the example config mount using extraVolumes and extraVolumeMounts but I much rather prefer this solution.

@merriadoc
Copy link

This pull request will be wonderfull ! :-)

@jompu jompu requested a review from exxbrain February 16, 2024 06:40
@kedare
Copy link

kedare commented Feb 22, 2024

Something that could be interesting to add, we should name the configmap dynamically with the name of the relase (like most others k8s objects I think right now)

As of today we cannot have multiple releases of apisix in a single namespace because of this (conflict on the fixed apisix.yaml configmap name)

… values and added option to set the rules configuration with an existing configmap.
@jompu jompu force-pushed the more-standalone-config-options branch from d37c54b to 142baa3 Compare June 17, 2024 10:08
@jompu jompu changed the base branch from dev to master June 17, 2024 10:08
@jompu
Copy link
Author

jompu commented Jun 17, 2024

The 2.x development has changed from dev to master since I created this, so I have updated the branch to match latest master. And this pull request to merge into master.

@jompu
Copy link
Author

jompu commented Jun 17, 2024

@Gallardot Maybe you can help to get this forward also.

The chart is not usable in standalone mode without this.

@bruhsb
Copy link

bruhsb commented Sep 4, 2024

hey folks o/

I'm facing the same issue, I needed to use strategicMergePatches in helmfile to rewrite the volume apisix-admin to use standalone mode with a custom configmap T_T

Can I do something to help this PR to move forward? :) @Gallardot

@ranjanashish
Copy link

@Gallardot @exxbrain Can one of you help move this forward please?

As others have noted, in its current state, this Helm chart is unusable for standalone mode. This is particularly surprising because even the FAQs has details on how to deploy APISIX in standalone mode. And yes, the command used in the FAQ will deploy APISIX in standalone mode but won't let you configure routes or anything - essentially it will deploy a dummy APISIX that is not usable.

@j4rj4r
Copy link

j4rj4r commented Dec 13, 2024

Hello !

This pull request is essential for ensuring a fully functional and easily deployable standalone mode.
As it stands, the current Helm chart configuration isn’t practical for automation or GitOps.

thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants