I have some trouble on route match

[zhuliquan]

Issue description

I set two routes like this:
##route1
{"uris":["/test/v1/files/*"],"name":"get_file1","desc":"get_file1","methods":["GET"],"vars":[],"plugins":{"proxy-rewrite":{"regex_uri":["^/test/v1/files/(.+)","/v1/files/$1"]}},"upstream_id":"333773215308464216"}
##route2
{"uris":["/test/v1/files:listReputationHistories"],"name":"list_reputation_history1","methods":["POST"],"vars":[],"plugins":{"proxy-rewrite":{"uri":"/v1/files:listReputationHistories"}},"upstream_id":"333773215308464216"}

But run command: curl "http://127.0.0.1:9080/test/v1/files:xxxdsadsadxxx" -XPOST -d {"uri":"xxx"} , It also can return results.
APISIX sames to match '/test/v1/files:xxxdsadsadxxx' to '"/test/v1/files:listReputationHistories'. I also try other cases: curl "http://127.0.0.1:9080/test/v1/files: {any string}" -XPOST -d {"uri":"xxx"} , APISIX sames ignore string behind ':'.

Environment

• apisix version (cmd: 2.1):

[Firstsawyou]

Can you provide a minimal reproducible use case?

[zhuliquan]

GRPC service

I use grpc build service
protobuf:

import "google/api/annotations.proto";
package test_grpc.api.file;

option go_package = ".;file";

message Request {
  string uri = 1;
}

message Response {
  string info = 1;
}

service File {
  rpc GetFile (Request) returns (Response) {
    option (google.api.http) = {
      get: "/v1/{uri=files/*}"
    };
  }
  rpc ListReputationHistories (Request) returns (Response) {
    option (google.api.http) = {
      post: "/v1/files:listReputationHistories"
    };
  }
}

service code.

func (s *FileServerImpl) GetFile(ctx context.Context, r *file.Request) (*file.Response, error) {
        return &file.Response{Info: "GetFile:" + r.GetUri()}, nil
}
func (s *FileServerImpl) ListReputationHistories(ctx context.Context, r *file.Request) (*file.Response, error) {
        return &file.Response{Info: "ListReputationHistories:" + r.GetUri()}, nil
}

I run service with prot:9201, and use grpc-gateway provide http service.

APISIX

upstreams:

curl -XPUT "http://127.0.0.1:9080/apisix/admin/upstreams/1" -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'  -d '{"nodes":{"host":"127.0.0.1:9201" : 1},  "type":"roundrobin", "name":"test_grpc_http"}'

routes:

curl -XPUT "http://127.0.0.1:9080/apisix/admin/routes/1" -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -d '{"uris":["/test/v1/files/*"],"name":"get_file1","methods":["GET"],"plugins":{"proxy-rewrite":{"regex_uri":["^/test/v1/files/(.+)","/v1/files/$1"]}},"upstream_id":"1"}'
curl -XPUT "http://127.0.0.1:9080/apisix/admin/routes/2" -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -d '{"uris":["/test/v1/files:listReputationHistories"],"name":"list_reputation_history1","methods":["POST"],"plugins":{"proxy-rewrite":{"uri":"/v1/files:listReputationHistories"}},"upstream_id":"1"}'

Fact

I send any post request with prefix /test/v1/files: , result is same with /test/v1/files:listReputationHistories
for example:
curl "http://127.0.0.1:9080/test/v1/files:esxxx" -XPOST -d {"uri":"xxx"}
{"info":"ListReputationHistories:"}(base)

`

[Firstsawyou]

The characters with : in the url here are very similar to the prefix path, right? @spacewander

[zhuliquan]

The characters with : in the url here are very similar to the prefix path, right? @spacewander

Yes, /test/v1/files:/test/v1/files:listReputationHistories and /test/v1/files:xxxxxxx will return same results, even I don't define route with /test/v1/files:xxxxxxx. APISIX ignore characters behind ':' , only match string "/test/v1/files" before ':'

[tokers]

See https://github.com/api7/lua-resty-radixtree#parameters-in-path, : in the Route of APISIX has special meanings.

[spacewander]

We need to fix it in lua-resty-radixtree. ":" is legal in uri and is recommended in RESTful API by Google: https://cloud.google.com/apis/design/custom_methods

[spacewander]

Added as api7/lua-resty-radixtree#82