Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support gRPC over SSL #3344

Closed
membphis opened this issue Jan 19, 2021 · 3 comments · Fixed by #3411
Closed

feat: support gRPC over SSL #3344

membphis opened this issue Jan 19, 2021 · 3 comments · Fixed by #3411
Labels
enhancement New feature or request
Milestone
2.3

Comments

@membphis
Copy link
Member

membphis commented Jan 19, 2021 •
edited
Loading

we do not support gRPC over SSL now, we can follow this way to support TLS + gRPC.

image

here is the current code, we can update it:
https://github.com/apache/apisix/blob/master/apisix/cli/ngx_tpl.lua#L546

image
@membphis membphis added the enhancement New feature or request label Jan 19, 2021
@membphis membphis changed the title feat: support tls + grpc feat: support gRPC over SSL Jan 19, 2021
@spacewander spacewander mentioned this issue Jan 19, 2021
Closed
@tokers
Copy link
Contributor

tokers commented Jan 20, 2021

The SNI pass should be supported in advance, with the related issue #2988 .

@spacewander spacewander added bug Something isn't working and removed bug Something isn't working labels Jan 20, 2021
@JanLi-air
Copy link

@membphis @spacewander @tokers Can you please advise when will we get this feature delivered? It might impact our planning.

@membphis membphis added this to the 2.3 milestone Jan 21, 2021
@membphis
Copy link
Member Author

I think we can fix this issue in milestone 2.3 (this month) @JanLi-air

@spacewander spacewander mentioned this issue Jan 21, 2021
Closed
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jan 25, 2021
@spacewander
feat: support gRPCS
862d50e 
Fix apache#3344.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander mentioned this issue Jan 25, 2021
Merged
4 tasks
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jan 25, 2021
@spacewander
feat: support gRPCS
8e6ede5 
Fix apache#3344.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jan 25, 2021
@spacewander
feat: support gRPCS
78fbb38 
Fix apache#3344.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jan 25, 2021
@spacewander
feat: support gRPCS
05c238c 
Fix apache#3344.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jan 25, 2021
@spacewander
feat: support gRPCS
a8b3597 
Fix apache#3344.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

feat: support gRPCS spacewander/incubator-apisix
4 participants
@spacewander @membphis @tokers @JanLi-air