discuss: Allow to set custom timeout for route when route belongs to service or upstream

[xuchmao]

Issue description

Need to config custom timeout for route when route belongs to service or upstream.
Sometimes we don't want to use timeout configured in service or upstream but use custom timeout instead.

Environment

apisix version (cmd: apisix version): 2.3

[spacewander]

Wait for more votes to see if this FR is widely needed.

[tokers]

@xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.

[tokers]

@xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.

Could you paste some cases in real world?

[lujiajing1126]

@xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.

Could you paste some cases in real world?

Obviously, uploading files should have longer timeout compared to a normal GET/POST

[FightingLiming]

When a service has multiple interfaces, the timeout period of each interface may be different.

[spacewander]

We can pass through the timeout via ctx:

apisix/apisix/balancer.lua

Lines 138 to 140 in 0114c98

	local up_conf = ctx.upstream_conf
	if up_conf.timeout then
	local timeout = up_conf.timeout

PR is welcome!

[yxudong]

Hi, @spacewander I'd like work on this issue.
Please assign it to me.
But what extent should this feature be supported, like just precise match or should supprt regex match?

[spacewander]

But what extent should this feature be supported, like just precise match or should supprt regex match?

I am confused. Doesn't we only need to add a timeout field as we have done with upstream?

[tokers]

Hi, @spacewander I'd like work on this issue.
Please assign it to me.
But what extent should this feature be supported, like just precise match or should supprt regex match?

It seems that what you talked about is another thing? If so, we may create another issue to track, and in this thread, let's talk about custom timeout settings.

[yxudong]

Sorry, I misunderstood.
I'll work on this issue about custom timeout settings.

[tokers]

Sorry, I misunderstood.
I'll work on this issue about custom timeout settings.

Looking forward to your PR :)

[yxudong]

The issue can be closed. @tokers

[tokers]

The issue can be closed. @tokers

Well done, thanks for your contribution!