help request: the minimum in healthcheck schema is incorrect

[spacewander]

Description

It's meaningless to use zero as the minimum:

apisix/apisix/schema_def.lua

Line 239 in d3ac217

minimum = 0,

We set them to zero because we wanted to use a default healthcheck in #5589.
However, as this PR is surpassed by #7850, there is no need to keep the zero value.

Environment

• APISIX version (run apisix version): master
• Operating system (run uname -a):
• OpenResty / Nginx version (run openresty -V or nginx -V):
• etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
• APISIX Dashboard version, if relevant:
• Plugin runner version, for issues related to plugin runners:
• LuaRocks version, for installation issues (run luarocks --version):

[Neilblaze]

@spacewander @navendu-pottekkat Can you assign me please if this is up for grabs?

[pottekkat]

Sure @Neilblaze cc: @spacewander

[Neilblaze]

@navendu-pottekkat I'm a bit confused about whether I'm going to break the tests by directly removing minimum = 0 or we need to set the props to a minimum of 1 or default at true?

Nonetheless, for now, I'm going with the former one i.e. I'm removing the minimum prop from successes.

[pottekkat]

@spacewander can chime in here.

[spacewander]

@navendu-pottekkat I'm a bit confused about whether I'm going to break the tests by directly removing minimum = 0 or we need to set the props to a minimum of 1 or default at true?

Nonetheless, for now, I'm going with the former one i.e. I'm removing the minimum prop from successes.

What do you mean 'default at true'? There is no default value in the healthcheck schema. Can you give some code as an example?

[spacewander]

If you mean the default value in

apisix/apisix/schema_def.lua

Line 263 in 8d38884

default = 2

it is not relative to the topic here.

[Neilblaze]

Gotcha! Thanks for the clarity @spacewander 😄
I'm moving forward with assigning minimum = 1 to here instead of removing minimum = 0 then.

I assume that we need to provide at least a floor to the minimum value, hence assigning 1

[github-actions]

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

[github-actions]

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

[pottekkat]

Closing this as it is confirmed that this is not an issue: #8949 (comment)