fix: invalid error after passive health check is changed #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzssangglass
approved these changes
Nov 23, 2021
membphis
approved these changes
Nov 23, 2021
bisakhmondal
approved these changes
Nov 23, 2021
spacewander
reviewed
Nov 24, 2021
|
|
||
|
|
||
|
|
||
| === TEST 13: number type timeout | ||
| === TEST 13: only active |
There was a problem hiding this comment.
Suggested change
| === TEST 13: only active | |
| === TEST 13: change active & passive to only active |
There was a problem hiding this comment.
The purpose of this test is to verify that the default passive configuration will be added in the case of active only. I think this title description is not very accurate, what do you think?
| }, | ||
| unhealthy = { | ||
| http_statuses = { 429, 500, 503 }, | ||
| tcp_failures = 0, |
There was a problem hiding this comment.
Is it necessary to set a zero default? Do we need to update the doc?
There was a problem hiding this comment.
Changing the value to 0 will disable the passive health check, which is necessary when only the active check is configured, documentation needs to be updated
spacewander
approved these changes
Nov 24, 2021
besich
pushed a commit
to besich/apisix
that referenced
this pull request
Dec 1, 2021
bzp2010
pushed a commit
to bzp2010/apisix
that referenced
this pull request
Dec 30, 2021
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Sep 2, 2022
This issue is introduced in the bugfix: apache#5589 This PR fixes the bug added by that bugfix, and also introduce a new test (TEST 6) to cover issue apache#4077. The fix of that issue is submitted in api7/lua-resty-healthcheck#5 which fixes the bug in an appropriate way. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FIX #4077
Pre-submission checklist: