fix: the leak of prometheus metrics #10655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Sn0rt
changed the title
AlinsRan
previously approved these changes
Dec 22, 2023
monkeyDluffy6017
changed the title
t/node/healthcheck-metric.t
Outdated
| ngx.say(body) | ||
| return | ||
| end | ||
| ngx.sleep(6) |
There was a problem hiding this comment.
It takes too long, try to replace delayed_clear with clear when run test cases
There was a problem hiding this comment.
This time is set after many attempts. 3, 4, and 5 have a small probability of causing the target to not be cleaned up in time enough.
I don't agree with using clear in test cases, it will make the test cases complicated and difficult to read.
- The checker cannot be obtained directly in the test case.
- The underlying health check library does not support directly calling functions to delete targets.
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
t/node/healthcheck-metric.t
Outdated
| obj.delayed_clear = obj.clear | ||
| return obj | ||
| end | ||
| --- timeout: 20 |
t/node/healthcheck-metric.t
Outdated
| local httpc = http.new() | ||
| local uri = "http://127.0.0.1:" .. ngx.var.server_port .. "/ping" | ||
| local _, _ = httpc:request_uri(uri, {method = "GET", keepalive = false}) | ||
| ngx.sleep(3) |
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
monkeyDluffy6017
approved these changes
Dec 25, 2023
AlinsRan
approved these changes
Dec 25, 2023
shreemaan-abhishek
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit 59a6be4.
shreemaan-abhishek
added a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #10636
Checklist