fix: stream route matcher is nil after first match #11269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #11259
this bug introduced in https://github.com/apache/apisix/pull/10298/files#diff-0234dd467ed66c3dffbef844397e9e7e018c287aab324ba8dd0b5a9e03b89360, I have no idea why made those changes,
![image](https://private-user-images.githubusercontent.com/22141303/332089537-dc21c62a-a689-4f0e-994d-acb1713d5c44.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDcxNDcsIm5iZiI6MTczOTYwNjg0NywicGF0aCI6Ii8yMjE0MTMwMy8zMzIwODk1MzctZGMyMWM2MmEtYTY4OS00ZjBlLTk5NGQtYWNiMTcxM2Q1YzQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4MDcyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2NmMyMjA3YzdmMThmNDNmMGE5ZjZjZjMzYTM5Yzg4YjNlOGFkMDA3ZWM3M2QzOWI5MmYwZTkzNGQ4ZTBlY2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1e4SR4kdMcHITgcxdhC6-4UZq63rhqF0fFoTDrbvou4)
![image](https://private-user-images.githubusercontent.com/22141303/332089555-0373f3cd-8697-4acf-944a-b48342b5732d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDcxNDcsIm5iZiI6MTczOTYwNjg0NywicGF0aCI6Ii8yMjE0MTMwMy8zMzIwODk1NTUtMDM3M2YzY2QtODY5Ny00YWNmLTk0NGEtYjQ4MzQyYjU3MzJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4MDcyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4ZWMzYjhhODE3YjU1N2UzMTVhY2IzM2RjYjk2YzcwZjU5NGJkOTBjN2ZkYjU0NDJjNDc1MDViYjgzNTk0ZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1pHb2q0P_kCTFeLB1JYzI9ovJV1yGXW-NNuxQ3pvIwg)
set
route.value.xxx_matcher
to nil is insane, the stream route only working in first matched request now, after first match, all requests to same stream route will be panic with nil matcher:Checklist