Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log] Optimize the buffer size and flush time #1570

Merged
merged 2 commits into from
Jun 7, 2020

Commits on May 11, 2020

  1. yousali:<log>Optimize the buffer size and flush time

    1. buffer=4096 is better for Writes of more than PIPE_BUF bytes may be nonatomic
    2. flush=1. Since the log buffer is lowered, the flush time should also be lowered.
    Miss-you committed May 11, 2020
    Configuration menu
    Copy the full SHA
    cdb18f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. yousali:<fix>

    hi, I also made a test.
    
    ```
    4096  Requests/sec:  16079.75
    8192 Requests/sec:  16389.52
    16384 Requests/sec:  16395.30
    32768 Requests/sec:  16459.71
    ```
    I think a log buffer size of 8192 or 16384 would be appropriate.
    
    On the other hand, the refresh time of 3 seconds is still relatively long, and 1 or 3 seconds doesn't particularly affect QPS.
    
    So I also agree with `buffer=16384 flush=1; `
    Miss-you committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    1844be4 View commit details
    Browse the repository at this point in the history