Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add a new option, decide if we remove the "/" at the end of … #1766

Merged
merged 3 commits into from
Jul 29, 2020
Merged

feature: add a new option, decide if we remove the "/" at the end of … #1766

merged 3 commits into from
Jul 29, 2020

Conversation

membphis
Copy link
Member

…the URI before route mathing.

fix #1765

@membphis
Copy link
Member Author

@apache/apisix-committers The default value, which one is better? true or false?

delete_uri_tail_slash: true

@ShiningRush
Copy link
Contributor

I think false would be better, no tricks when matching route except user want.
So can ensure users know what happen when them set true

@membphis
Copy link
Member Author

I think false would be better, no tricks when matching route except user want.
So can ensure users know what happen when them set true

Ok, I have updated the processing logic.

@membphis membphis merged commit f9a8a26 into apache:master Jul 29, 2020
@membphis membphis deleted the delete-uri-end-slash branch July 29, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxthrj gxthrj gxthrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: add a new option, decide if we remove the "/" at the end of the URI before route mathing
3 participants
@membphis @ShiningRush @gxthrj