Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: route accroding to the graphql attributes #2964

Merged
merged 4 commits into from
Dec 10, 2020
Merged

feat: route accroding to the graphql attributes #2964

merged 4 commits into from
Dec 10, 2020

Conversation

spacewander
Copy link
Member

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander marked this pull request as ready for review December 4, 2020 09:50
@spacewander spacewander marked this pull request as draft December 4, 2020 10:57
@spacewander spacewander marked this pull request as ready for review December 7, 2020 02:23
membphis
membphis reviewed Dec 8, 2020
View reviewed changes
apisix/core/ctx.lua Outdated
return nil, "empty graphql: " .. body
end

return res, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return res be fine

apisix/core/ctx.lua Outdated Show resolved Hide resolved
apisix/core/ctx.lua Show resolved Hide resolved
t/lib/test_admin.lua Show resolved Hide resolved
@spacewander
tweak
67c0ede 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@membphis
Copy link
Member

membphis commented Dec 8, 2020

@JanLi-air do you have time to look at this PR?

membphis
membphis approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except minor code style things

apisix/core/ctx.lua Outdated Show resolved Hide resolved
@spacewander
style
0f44ca2 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@moonming moonming added this to the 2.2 milestone Dec 10, 2020
@moonming moonming merged commit 93e2f16 into apache:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@spacewander @membphis @moonming