Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch resolver to lua-resty-dns-client #3442

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Jan 28, 2021

Fix #2532
Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander force-pushed the dns-client branch 6 times, most recently from e33c5fb to 60ad587 Compare January 28, 2021 11:33
@jenskeiner
Copy link
Contributor

Hey, thanks for taking care of this DNS issue.

I've been bitten by this as well in a K8s environment where I want to refer to services just by their name w/o the full domain part which is environment-specific. Let me know in case I can help with anything. Otherwise, looking forward to seeing this merged to master. +1

@spacewander spacewander force-pushed the dns-client branch 3 times, most recently from 89d4050 to a6e4248 Compare January 29, 2021 02:22
@spacewander
Copy link
Member Author

We are planning to release 2.3, so this PR will be merged later. There will be more DNS relative new features in the coming 2.4 version.
CC @gy09535

@spacewander spacewander marked this pull request as ready for review February 1, 2021 04:03
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander merged commit 563b259 into apache:master Feb 2, 2021
@spacewander spacewander deleted the dns-client branch February 2, 2021 01:07
@gy09535
Copy link
Contributor

gy09535 commented Feb 4, 2021

We are planning to release 2.3, so this PR will be merged later. There will be more DNS relative new features in the coming 2.4 version.
CC @gy09535

good, got it.

@ShaoZeMing
Copy link

I found a problem. At present, after using this dns client, upstream services can implement dns search, but in plugins, when resty.http is used to generate requests, dns search cannot be implemented. Is there a way to deal with this?

@membphis
Copy link
Member

membphis commented Mar 1, 2021

@ShaoZeMing Welcome to create a new journal to discuss your questions. This PR has been merged, which means it is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Apisix upstream domain resolver can not support "search xxxx, options xxxxx" in k8s environment
6 participants