-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail to run make deps
on macOS
#3718
Conversation
@@ -150,7 +150,10 @@ nohup etcd & | |||
|
|||
```shell | |||
# install OpenResty, etcd and some compilation tools | |||
brew install openresty/brew/openresty etcd luarocks curl git | |||
brew install openresty/brew/openresty openresty-openssl111 etcd curl git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember openresty-openssl111 is a dependency of openresty, will it be installed automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, or-openssl111 will be autoaticll installed when you install openresty
will update later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the mac os scenario, we should do this:
- Install lua 5.1:
brew install lua@5.1
- When calling the luarocks command in make deps, add the parameter
--lua-dir=/usr/local/opt/lua@5.1
, eg:luarocks --lua-dir=/usr/local/opt/lua@5.1 ***
we use |
update to use brew to install luarocks. please have a look when you have time. @membphis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@totemofwolf welcome to take a look and make a try with this PR, it should work for mac os.
What this PR does / why we need it:
fix script and docs about install dependencies on macOS
Pre-submission checklist: