Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't override cache relative headers #3789

Merged
merged 1 commit into from
Mar 10, 2021
Merged

fix: don't override cache relative headers #3789

merged 1 commit into from
Mar 10, 2021

Conversation

spacewander
Copy link
Member

Fix #3373
Fix #3677

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix: don't override cache relative headers
63d883b 
Fix apache#3373
Fix apache#3677

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review March 9, 2021 10:01
juzhiyuan
juzhiyuan approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from logics

@spacewander spacewander merged commit d538105 into apache:master Mar 10, 2021
@spacewander spacewander deleted the not_cache_override branch March 10, 2021 01:04
@spacewander spacewander mentioned this pull request May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@membphis membphis Awaiting requested review from membphis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@spacewander @juzhiyuan @tokers