change(echo): remove odd auth_value #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Apr 15, 2021
| @@ -45,7 +45,6 @@ This plugin addresses the corresponding functionality in the common phases such | |||
| | body | string | optional | | | Body to replace upstream response. | | |||
| | after_body | string | optional | | | Body after the modification of filter phase. | | |||
| | headers | object | optional | | | New headers for response | | |||
| | auth_value | string | optional | | | Auth value | | |||
There was a problem hiding this comment.
We need to remove it from the source & test too.
spacewander
changed the title
batman-ezio
force-pushed
the
doc/issue_3974
branch
from
c48fe1d
to
cebd8d7
Compare
|
@batman-ezio The CI is still failed. |
spacewander
approved these changes
May 28, 2021
Yiyiyimu
approved these changes
May 28, 2021
tao12345666333
added a commit
to tao12345666333/ingress-controller
that referenced
this pull request
Jun 7, 2021
it has been removed. xref: apache/apisix#4055 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
gxthrj
pushed a commit
to apache/apisix-ingress-controller
that referenced
this pull request
Jun 8, 2021
it has been removed. xref: apache/apisix#4055 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be done with key-auth plugin.
What this PR does / why we need it:
Pre-submission checklist:
Fix #3974