Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: be compatible with the router created before 2.5 #4056

Merged
merged 1 commit into from
Apr 15, 2021
Merged

fix: be compatible with the router created before 2.5 #4056

merged 1 commit into from
Apr 15, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix: be compatible with the router created before 2.5
b67aa79 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander changed the title fix: be compatibile with the router created before 2.5 fix: be compatible with the router created before 2.5 Apr 15, 2021
@spacewander spacewander mentioned this pull request Apr 15, 2021
Closed
Firstsawyou
Firstsawyou reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@Firstsawyou Firstsawyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@spacewander spacewander merged commit 5259b8c into apache:master Apr 15, 2021
@spacewander spacewander deleted the fcr branch April 15, 2021 08:24
@Firstsawyou Firstsawyou mentioned this pull request Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firstsawyou Firstsawyou Firstsawyou left review comments

@tokers tokers tokers approved these changes

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spacewander @membphis @tokers @Firstsawyou