feat(reponse-rewrite): allow using variable in the header #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix apache#3727 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
reviewed
May 7, 2021
| @@ -46,7 +46,7 @@ response rewrite plugin, rewrite the content returned by the upstream as well as | |||
| | status_code | integer | optional | | [200, 598] | New `status code` to client, keep the original response code by default. | | |||
| | body | string | optional | | | New `body` to client, and the content-length will be reset too. | | |||
| | body_base64 | boolean | optional | false | | Identify if `body` in configuration need base64 decoded before rewrite to client. | | |||
| | headers | object | optional | | | Set the new `headers` for client, can set up multiple. If it exists already from upstream, will rewrite the header, otherwise will add the header. You can set the corresponding value to an empty string to remove a header. | | |||
| | headers | object | optional | | | Set the new `headers` for client, can set up multiple. If it exists already from upstream, will rewrite the header, otherwise will add the header. You can set the corresponding value to an empty string to remove a header. The value can contain Nginx variable in `$var` format, like `$remote_addr $balancer_ip` | | |||
There was a problem hiding this comment.
Suggested change
| | headers | object | optional | | | Set the new `headers` for client, can set up multiple. If it exists already from upstream, will rewrite the header, otherwise will add the header. You can set the corresponding value to an empty string to remove a header. The value can contain Nginx variable in `$var` format, like `$remote_addr $balancer_ip` | | |
| | headers | object | optional | | | Set the new `headers` for client, can set up multiple. If it exists already from upstream, will rewrite the header, otherwise will add the header. You can set the corresponding value to an empty string to remove a header. The value can contain Nginx variables in `$var` format, like `$remote_addr $balancer_ip` | |
t/plugin/response-rewrite.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 24: rewrite header with variable |
There was a problem hiding this comment.
Suggested change
| === TEST 24: rewrite header with variable | |
| === TEST 24: rewrite header with variables |
Yiyiyimu
approved these changes
May 7, 2021
Firstsawyou
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3727
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: