Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: enable stream proxy only by default #4580

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@gxthrj
Copy link
Contributor

gxthrj commented Jul 10, 2021

It is confusing for using the configuration in stream-proxy to control the http-proxy.
It is better to keep configuration the same level with stream and http proxy.

@spacewander
Copy link
Member Author

The HTTP proxy already at the top level of apisix. There can't be "the same level" unless we downgrade the level of HTTP proxy.

@spacewander spacewander merged commit 03a9b80 into apache:master Jul 14, 2021
@spacewander spacewander deleted the son branch July 14, 2021 02:33
@oldthreefeng
Copy link

so, You need to declare only this is a global variable. otherwise confused .....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants