-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update how-to-build.md #5136
Conversation
add command make install in case of `command not found`
@@ -76,6 +76,8 @@ Please refer to: [Installing Apache APISIX with Helm Chart](https://github.com/a | |||
cd apisix-2.9 | |||
# Create dependencies | |||
make deps | |||
# Install apisix command | |||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update CN version at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think make install
means installing the APISIX code into luarocks. The context here is to download the APISIX source code, so does the source code still need to be installed to luarocks? I thought it was no longer needed. what's your option? @spacewander @membphis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. See the comment here:
Line 167 in 6162ca0
### install: Install the apisix (only for luarocks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my mind. Look like we still need this command to install APISIX to PATH even make install
is designed for luarocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no other command to do it.
sync with en, and sync with apache#5075
why we change
|
english version has been changed in #5075, so chinese version follow up |
got |
See apache#5136 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
add command make install in case of
command not found
What this PR does / why we need it:
Pre-submission checklist: