Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update how-to-build.md #5136

Merged
merged 3 commits into from
Sep 29, 2021
Merged

docs: update how-to-build.md #5136

merged 3 commits into from
Sep 29, 2021

Conversation

candyleer
Copy link
Member

add command make install in case of command not found

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

add command make install in case of `command not found`
@candyleer candyleer changed the title Update how-to-build.md docs: update how-to-build.md Sep 24, 2021
@@ -76,6 +76,8 @@ Please refer to: [Installing Apache APISIX with Helm Chart](https://github.com/a
cd apisix-2.9
# Create dependencies
make deps
# Install apisix command
make install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CN version at the same time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think make install means installing the APISIX code into luarocks. The context here is to download the APISIX source code, so does the source code still need to be installed to luarocks? I thought it was no longer needed. what's your option? @spacewander @membphis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. See the comment here:

apisix/Makefile

Line 167 in 6162ca0

### install: Install the apisix (only for luarocks)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind. Look like we still need this command to install APISIX to PATH even make install is designed for luarocks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no other command to do it.

@tzssangglass
Copy link
Member

why we change make * to apisix *? for example, if apisix is not in the path search variable, you will get error as command not found.

make stop = ./bin/apisix stop, it works well.

@candyleer
Copy link
Member Author

why we change make * to apisix *? for example, if apisix is not in the path search variable, you will get error as command not found.

make stop = ./bin/apisix stop, it works well.

english version has been changed in #5075, so chinese version follow up

@tzssangglass
Copy link
Member

why we change make * to apisix *? for example, if apisix is not in the path search variable, you will get error as command not found.
make stop = ./bin/apisix stop, it works well.

english version has been changed in #5075, so chinese version follow up

got

spacewander added a commit to spacewander/incubator-apisix that referenced this pull request Sep 26, 2021
See apache#5136 (comment)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants