Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins #6055

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins #6055

merged 1 commit into from
Jan 13, 2022

Conversation

zhendongcmss
Copy link
Contributor

@zhendongcmss zhendongcmss commented Jan 10, 2022 •
edited
Loading

fix #6011

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@zhendongcmss zhendongcmss mentioned this pull request Jan 10, 2022
Closed
4 tasks
@zhendongcmss zhendongcmss marked this pull request as ready for review January 10, 2022 03:12
spacewander
spacewander reviewed Jan 10, 2022
View reviewed changes
t/plugin/prometheus3.t Show resolved Hide resolved
apisix/utils/batch-processor.lua Outdated Show resolved Hide resolved
@zhendongcmss zhendongcmss force-pushed the batch-master branch 3 times, most recently from f5f255e to 33e6e68 Compare January 12, 2022 02:10
@zhendongcmss
Copy link
Contributor Author

@tzssangglass Pls help review

@spacewander spacewander merged commit f3d7550 into apache:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: prometheus labels is inconsistent when using the same batch-processor in mutil logger plugins
3 participants
@zhendongcmss @spacewander @tzssangglass