docs: modify the make install in how to build Apache APISIX doc #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/en/latest/how-to-build.md
Outdated
Comment on lines
128
to
129
| # Install apisix command (only for luarocks) | ||
| make install |
There was a problem hiding this comment.
rm make install is better?
There was a problem hiding this comment.
Yes. We can rename this task and claim that the developer should not try to "install" the source.
There was a problem hiding this comment.
@bin-ya I think Install apisix command (only for luarocks) should be changed to Install apisix command (developer do not need to follow this step)
tzssangglass
previously approved these changes
Mar 21, 2022
spacewander
reviewed
Mar 21, 2022
docs/en/latest/how-to-build.md
Outdated
| @@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package. | |||
| cd apisix-${APISIX_VERSION} | |||
| # Create dependencies | |||
| make deps | |||
| # Install apisix command | |||
| # Install apisix command (developer do not need to follow this step) | |||
There was a problem hiding this comment.
I am confused. If it is no need, why not remove it?
There was a problem hiding this comment.
let's remove it. cc @bin-ya
tzssangglass
previously approved these changes
Mar 21, 2022
leslie-tsang
previously approved these changes
Mar 21, 2022
spacewander
reviewed
Mar 21, 2022
| @@ -125,8 +125,6 @@ Follow the steps below to install Apache APISIX via the source release package. | |||
| cd apisix-${APISIX_VERSION} | |||
| # Create dependencies | |||
| make deps | |||
| # Install apisix command | |||
| make install | |||
There was a problem hiding this comment.
We can also remove make uninstall?
spacewander
approved these changes
Mar 22, 2022
tzssangglass
approved these changes
Mar 22, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #6559
Checklist