docs: fix links to OpenTelemetry specification #6711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Mar 24, 2022
|
|
||
| Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlphttp-request)。 | ||
| Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://opentelemetry.io/docs/reference/specification/protocol/otlp/#otlphttp-request). |
There was a problem hiding this comment.
Note that this sentence doesn't really make sense grammatically. (I chose to only update the link. I'll let someone else rework the sentence if you feel that is necessary.
There was a problem hiding this comment.
Thanks for your suggestion, would you like to have it a try ?
There was a problem hiding this comment.
Sure I can give it a try tomorrow.
chalin
changed the title
chalin
added a commit
to chalin/apisix
that referenced
this pull request
Mar 24, 2022
- Context: open-telemetry/opentelemetry.io#1185 - This is the zh counterpart to apache#6711. /cc @austinlparker
spacewander
changed the title
spacewander
changed the title
spacewander
changed the title
spacewander
approved these changes
Mar 25, 2022
leslie-tsang
approved these changes
Mar 25, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: open-telemetry/opentelemetry.io#1185
/cc @austinlparker