Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jwt-auth error may leak secret #6846

Merged
merged 4 commits into from
Apr 14, 2022
Merged

fix: jwt-auth error may leak secret #6846

merged 4 commits into from
Apr 14, 2022

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Apr 14, 2022 •
edited
Loading

Description

The jwt-auth plugin's response body may leak secrets in error message

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander spacewander merged commit 61a48a2 into apache:master Apr 14, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Apr 15, 2022
@bzp2010 @spacewander
fix: jwt-auth error may leak secret (apache#6846)
7789af1
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@bzp2010 @Liu-Junlin
fix: jwt-auth error may leak secret (apache#6846)
2cf89e2
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request May 27, 2022
@bzp2010 @spacewander
fix: jwt-auth error may leak secret (apache#6846)
4a5d325
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@bzp2010 @spacewander
fix: jwt-auth error may leak secret (#6846)
daeda3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslie-tsang leslie-tsang leslie-tsang approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@moonming moonming moonming approved these changes

@spacewander spacewander spacewander approved these changes

@membphis membphis Awaiting requested review from membphis

@shuaijinchao shuaijinchao Awaiting requested review from shuaijinchao

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzp2010 @spacewander @moonming @tzssangglass @leslie-tsang