feat: support hook response body for ext-plugin #6968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Apr 29, 2022
spacewander
reviewed
May 6, 2022
spacewander
reviewed
May 6, 2022
added 4 commits
May 6, 2022 17:57
tzssangglass
reviewed
May 7, 2022
| function _M.before_proxy(conf, ctx) | ||
| local http_obj = get_http_obj(ctx) | ||
| local res, err = get_response(ctx, http_obj) | ||
| if not res or err then |
There was a problem hiding this comment.
Line 100 has judgment that res is nil?
spacewander
reviewed
May 7, 2022
|
|
||
| if code == 0 then | ||
| -- runner change body only, we should set code. | ||
| code = body and res.status or nil |
There was a problem hiding this comment.
Look like it's covered in ngx.status = code or res.status?
added 4 commits
May 7, 2022 14:11
spacewander
reviewed
May 8, 2022
spacewander
reviewed
May 9, 2022
spacewander
approved these changes
May 10, 2022
tzssangglass
approved these changes
May 10, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support hook response body for ext-plugin
Checklist