-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust some list uris of V3 API #7364
Merged
+163
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
use t::APISIX 'no_plan'; | ||
|
||
repeat_each(1); | ||
no_long_string(); | ||
no_root_location(); | ||
no_shuffle(); | ||
log_level("info"); | ||
|
||
add_block_preprocessor(sub { | ||
my ($block) = @_; | ||
|
||
if (!$block->request) { | ||
$block->set_value("request", "GET /t"); | ||
} | ||
|
||
if (!$block->no_error_log && !$block->error_log) { | ||
$block->set_value("no_error_log", "[error]\n[alert]"); | ||
} | ||
}); | ||
|
||
run_tests; | ||
|
||
__DATA__ | ||
|
||
=== TEST 1: test /apisix/admin/protos/{id} | ||
--- config | ||
location /t { | ||
content_by_lua_block { | ||
local t = require("lib.test_admin").test | ||
local code, message = t('/apisix/admin/protos/1', | ||
ngx.HTTP_PUT, | ||
[[{ | ||
"content": "syntax = \"proto3\"; | ||
package proto; | ||
message HelloRequest{ | ||
string name = 1; | ||
} | ||
|
||
message HelloResponse{ | ||
int32 code = 1; | ||
string msg = 2; | ||
} | ||
// The greeting service definition. | ||
service Hello { | ||
// Sends a greeting | ||
rpc SayHi (HelloRequest) returns (HelloResponse){} | ||
}" | ||
}]], | ||
[[ | ||
{ | ||
"action": "set" | ||
} | ||
]] | ||
) | ||
|
||
if code ~= 200 then | ||
ngx.status = code | ||
ngx.say("[put proto] code: ", code, " message: ", message) | ||
return | ||
end | ||
|
||
ngx.say("[put proto] code: ", code, " message: ", message) | ||
} | ||
} | ||
--- response_body | ||
[put proto] code: 200 message: passed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
use t::APISIX 'no_plan'; | ||
|
||
repeat_each(1); | ||
no_long_string(); | ||
no_root_location(); | ||
no_shuffle(); | ||
log_level("info"); | ||
|
||
add_block_preprocessor(sub { | ||
my ($block) = @_; | ||
|
||
if (!$block->request) { | ||
$block->set_value("request", "GET /t"); | ||
} | ||
|
||
if (!$block->no_error_log && !$block->error_log) { | ||
$block->set_value("no_error_log", "[error]\n[alert]"); | ||
} | ||
}); | ||
|
||
run_tests; | ||
|
||
__DATA__ | ||
|
||
=== TEST 1: test /apisix/admin/ssls/{id} | ||
--- config | ||
location /t { | ||
content_by_lua_block { | ||
local core = require("apisix.core") | ||
local etcd = require("apisix.core.etcd") | ||
local t = require("lib.test_admin") | ||
|
||
local ssl_cert = t.read_file("t/certs/apisix.crt") | ||
local ssl_key = t.read_file("t/certs/apisix.key") | ||
local data = {cert = ssl_cert, key = ssl_key, sni = "test.com"} | ||
|
||
local code, body = t.test('/apisix/admin/ssls/1', | ||
ngx.HTTP_PUT, | ||
core.json.encode(data), | ||
[[{ | ||
"node": { | ||
"value": { | ||
"sni": "test.com" | ||
}, | ||
"key": "/apisix/ssl/1" | ||
}, | ||
"action": "set" | ||
}]] | ||
) | ||
|
||
ngx.status = code | ||
ngx.say(body) | ||
|
||
local res = assert(etcd.get('/ssl/1')) | ||
tzssangglass marked this conversation as resolved.
Show resolved
Hide resolved
|
||
local prev_create_time = res.body.node.value.create_time | ||
assert(prev_create_time ~= nil, "create_time is nil") | ||
local update_time = res.body.node.value.update_time | ||
assert(update_time ~= nil, "update_time is nil") | ||
|
||
} | ||
} | ||
--- response_body | ||
passed |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should delete
ssl
, all right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a break change, if so, we need to do a lot of changes to test cases and docs, which can cause conflicts when next merge to master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can first implement the function to update test cases, documents and uri on master after next merge to master?