Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade lua-resty-etcd to 1.8.3 #7565

Merged
merged 3 commits into from
Aug 2, 2022
Merged

chore: upgrade lua-resty-etcd to 1.8.3 #7565

merged 3 commits into from
Aug 2, 2022

Conversation

tzssangglass
Copy link
Member

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass
Copy link
Member Author

remove two no_error_log in t/deployment/conf_server.t.

  1. health-check in lua-resty-etcd is not support ipv6, ref: request help: apisix doesn't support etcd ipv6 endpoints #7100
  2. x.com would get timeout because it is not a real host.

both of these can cause

2022/08/01 16:51:22 [error] 30339#30339: [lua] init.lua:94: http_init(): failed to load the configuration:

@tzssangglass tzssangglass marked this pull request as ready for review August 1, 2022 11:39
@tzssangglass
Copy link
Member Author

This PR will need to be placed in the 2.15.1 LTS release in the future.

@spacewander spacewander merged commit 9749a9c into apache:master Aug 2, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Aug 17, 2022
@tzssangglass @spacewander
chore: upgrade lua-resty-etcd to 1.8.3 (apache#7565)
add2337 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander pushed a commit that referenced this pull request Aug 17, 2022
@tzssangglass @spacewander
chore: upgrade lua-resty-etcd to 1.8.3 (#7565)
bae4a9b 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@tzssangglass tzssangglass deleted the etcd183 branch October 10, 2022 10:42
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@tzssangglass @Liu-Junlin
chore: upgrade lua-resty-etcd to 1.8.3 (apache#7565)
1e79366
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Nov 9, 2022
@tzssangglass @spacewander
chore: upgrade lua-resty-etcd to 1.8.3 (apache#7565)
124b804
spacewander pushed a commit that referenced this pull request Nov 10, 2022
@tzssangglass @spacewander
chore: upgrade lua-resty-etcd to 1.8.3 (#7565)
4ca7183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulbird soulbird soulbird approved these changes

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzssangglass @spacewander @tokers @soulbird