Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: update list URIs for V3 feature #7622

Merged
merged 6 commits into from
Aug 10, 2022

Conversation

tzssangglass
Copy link
Member

Description

Fixes #7320

It is sister PR of #7364

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass tzssangglass added this to the 3.0 milestone Aug 8, 2022
@tzssangglass tzssangglass marked this pull request as ready for review August 8, 2022 03:37
spacewander
spacewander previously approved these changes Aug 8, 2022
@tzssangglass
Copy link
Member Author

should we update the key prefix that store in etcd, like: https://github.com/apache/apisix/blob/master/apisix/admin/ssl.lua#L76

@spacewander
Copy link
Member

should we update the key prefix that store in etcd, like: https://github.com/apache/apisix/blob/master/apisix/admin/ssl.lua#L76

Agree. Let's do it.

tokers
tokers previously approved these changes Aug 9, 2022
@tzssangglass tzssangglass dismissed stale reviews from tokers and spacewander via 7950017 August 9, 2022 01:26
@spacewander spacewander merged commit ccc43ea into apache:master Aug 10, 2022
@tzssangglass tzssangglass deleted the v3_list_uri branch October 10, 2022 10:42
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: new API design for the Admin API
4 participants