fix: reload once when log rotate #7869
Conversation
monkeyDluffy6017
changed the title
|
Is it feasible to add some test cases? |
We have log-rotate.t, log-rotate2.t, log-rotate3.t 3 test files to test its functionality. |
apisix/plugins/log-rotate.lua
Outdated
|
|
||
| local new_tab = require "table.new" | ||
| local ngx_sleep = require("apisix.core.utils").sleep | ||
| local isempty = require "table.isempty" |
There was a problem hiding this comment.
Better to introduce it via core.table
apisix/plugins/log-rotate.lua
Outdated
| if enable_compression then | ||
| -- Waiting for nginx reopen files | ||
| -- to avoid losing logs during compression | ||
| ngx_sleep(wait_time) |
There was a problem hiding this comment.
Will the sleep block the timer and cause the next rotation time incorrect?
There was a problem hiding this comment.
wait_time is just 0.5s by default. rotation time is much lager than 0.5s, right?
There was a problem hiding this comment.
@monkeyDluffy6017
Currently, there is no limitation for the user-specific wait_time. BTW, we need to doc it if this argument is exposed to the user.
There was a problem hiding this comment.
If the wait time is only for hardcode, maybe we can add extra sleep in the test so we don't need to set a special value.
* upstream/master: (214 commits) feat: set constants.apisix_lua_home for used by plugins (apache#7893) fix: response-rewrite plugin might cause Apache AIPSIX hanging (apache#7836) test: sleep 1 second in t/cli/test_upstream_mtls.sh (apache#7889) fix: reload once when log rotate (apache#7869) change: move etcd conf under deployment (apache#7860) fix: plugin metadata missing v3 adapter call (apache#7877) docs: add ClickHouse and Elasticsearch loggers. (apache#7848) docs(plugin): refactor limit-conn.md (apache#7857) feat: call `destroy` method when Nginx exits (apache#7866) feat: Add ability to inject headers via prefix to otel traces (apache#7822) docs(plugin): refactor proxy-cache.md (apache#7858) fix: don't enable passive healthcheck by default (apache#7850) feat: add openfunction plugin (apache#7634) fix(zipkin): send trace IDs with a reject sampling decision (apache#7833) fix: Change opentelemetry's span kind to server (apache#7830) docs(hmac-auth): additional details for generating signing_string (apache#7816) docs: correct the test-nginx description (apache#7818) docs: add docs of workflow plugin (apache#7813) docs(FAQ): add how to detect APISIX alive status (apache#7812) feat: add elasticsearch-logger (apache#7643) ...
Description
Checklist