Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some comment for make_request_to_vault function #8420

Merged
merged 1 commit into from
Dec 2, 2022
Merged

chore: add some comment for make_request_to_vault function #8420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apisix/kms/vault.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ local rfind_char = core.string.rfind_char

local _M = {}


-- This code is copied from apisix/core/vault.lua.
-- The functions in apisix/core/vault.lua are currently only used in the jwt-auth plugin,
-- and it is not suitable to be placed in the core module of APISIX.
--
-- When KMS is fully functional, we will remove apisix/core/vault.lua.
--
local function make_request_to_vault(conf, method, key, data)
local httpc = http.new()
-- config timeout or default to 5000 ms
Expand Down