Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: rename kms to secret #8448

Merged
merged 4 commits into from
Dec 6, 2022
Merged

change: rename kms to secret #8448

merged 4 commits into from
Dec 6, 2022

Conversation

soulbird
Copy link
Contributor

@soulbird soulbird commented Dec 2, 2022 •
edited
Loading

Description

Fixes # #8319 (comment)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@soulbird soulbird marked this pull request as ready for review December 2, 2022 09:46
@spacewander spacewander merged commit ba22a43 into apache:master Dec 6, 2022
This was referenced Jan 11, 2023
Closed
Merged
@shreemaan-abhishek
Copy link
Contributor

In some places kms hasn't yet been updated to secret. This has been fixed in: #8697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soulbird @shreemaan-abhishek @spacewander @tzssangglass