-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change the file name to 'create-ssl.py'.If 'ssl.py' is used as … #8623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a standalone test to show us why changing a filename can fix "AttributeError: module 'requests' has no attribute 'put'"?
在用python 执行脚本时, 脚本的所在路径会被加入 sys.path 中。比如在脚本中加入 print ("sys.path = ", sys.path), 会得到:
E:\xrd\code\tmp 是测试脚本 ssl.py 所在的目录。 |
test:
use create-ssl.py
|
LGTM. So |
…the file name, an error occurs.AttributeError: module 'requests' has no attribute 'put'
d1906de
to
ffbe91c
Compare
The problem has been fixed |
Can this commit be merged ? Thanks ! @spacewander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuruidong thank you for this PR. This looks good. You can also add a title to the code block to explicitly specify filename as we do in other documents like here: https://github.com/apache/apisix/blob/release/3.1/docs/en/latest/installation-guide.md?plain=1#L255
If you can add that title, you can omit the comment "save this file as ..." from each of these documentation pages.
This is also mentioned in our documentation style guide: https://apisix.apache.org/docs/general/documentation-style-guide/#formatting-punctuation-and-organization
Sorry for nitpicking, but consistency = quality. In the future, everyone will take it up themselves to follow the style guide.
Code block titles are added. Please review again, thank you ! |
* upstream/master: docs: change the file name to 'create-ssl.py'.If 'ssl.py' is used as … (apache#8623) feat: Body transformer plugin (apache#8766) fix: mocking plugin panic when response_example contain $ (apache#8810) (apache#8816) feat: file logger plugin support response body in variable (apache#8711) docs(getting-started): rewrite the install section (apache#8807) feat: allow each logger to define custom log format in its conf (apache#8806) fix(etcd): reloaded data may be in res.body.node (apache#8736) fix: fix fetch all service info from consul (apache#8651) docs: fix global-rule.md wrong curl address (apache#8793) feat: stream subsystem support consul service discovery (apache#8696) chore(kafka-logger): support configuration `meta_refresh_interval` parameter (apache#8762) feat: ready to release 2.15.2 (apache#8783)
…the file name, an error occurs.AttributeError: module 'requests' has no attribute 'put'
Description
Change the file name to "create-ssl.py" in certificate.md.
If "ssl.py" is used as the file name, an error occurs.
Fixes # (issue)
Checklist