Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java: bring Flight SQL driver on par with Go Flight SQL driver #745

Closed
Tracked by #1490
lidavidm opened this issue Jun 8, 2023 · 4 comments · Fixed by #1517
Closed
Tracked by #1490

java: bring Flight SQL driver on par with Go Flight SQL driver #745

lidavidm opened this issue Jun 8, 2023 · 4 comments · Fixed by #1517
Milestone
ADBC Libraries 0....

Comments

@lidavidm
Copy link
Member

lidavidm commented Jun 8, 2023

No description provided.

@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Jun 8, 2023
@lidavidm lidavidm removed this from the ADBC Libraries 0.8.0 milestone Sep 22, 2023
@jduo
Copy link
Member

jduo commented Jan 22, 2024 •
edited
Loading

Would it be possible to provide some guidance as far as what deficiencies exist between the Java and Go Flight SQL Drivers @lidavidm @zeroshade ?

@jduo
Copy link
Member

jduo commented Jan 22, 2024

It seems like it'd make sense to complete
#605 and #572 as part of this work?

@lidavidm
Copy link
Member Author

Auth, the general metadata methods, incremental/nonblocking query execution, transactions, and rich error metadata I think are the main ones

@lidavidm lidavidm mentioned this issue Jan 24, 2024
Closed
26 tasks
@jduo
Copy link
Member

jduo commented Feb 18, 2024

The work in #1517 implements getObjects() but not getTableTypes(), incremental queries, and transactions. Error messages were improved in #1487

Let's move the other features to separate issues so that this one can be closed. It will enable alot more functionality.

@jduo jduo mentioned this issue Feb 18, 2024
Merged
@github-actions github-actions bot added this to the ADBC Libraries 0.11.0 milestone Feb 18, 2024
lidavidm pushed a commit that referenced this issue Feb 18, 2024
@jduo @tokoko
feat(java/driver/flight-sql): implement getObjects (#1517)
adfb70a 
* Implement getObjects and each depth (CATALOGS, DB_SCHEMAS, TABLES, and
ALL).
* Handle the cases where the catalog is empty or a schema within a
catalog has no tables.
* Unify readers for queries, getInfo(), and getObjects() so that all
code paths can correctly get data when the data is not available on the
same location as the original connection, can handle multiple roots from
the same stream, and can handle multiple partitions.
* Rework getInfo() request to lazily issue an RPC call only if a request
code was used that needs information from the Flight server.

Fixes #745

---------

Co-authored-by: tokoko <togurg14@freeuni.edu.ge>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.10.0
Development

Successfully merging a pull request may close this issue.

feat(java/driver/flight-sql): implement getObjects Bit-Quill/arrow-adbc
2 participants
@lidavidm @jduo