fix(go/adbc/driver/snowflake): handle non-arrow result sets #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Jul 17, 2023
Comment on lines
359
to
360
| // XXX: there IS data in this result set, but Snowflake doesn't | ||
| // appear to support getting the results as Arrow |
|
@lidavidm Hm. In theory we probably could upstream more of this than I did. Right now the only thing I upstreamed was making the The only drawback to pushing this upstream is that it puts us back into the situation where we run into problems between the Arrow major version in snowflake vs the Arrow major version in ADBC. Right now we get to avoid that issue by having the conversion here. |
|
Ok, sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #863