Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4: Update package name #88

Merged
merged 1 commit into from
Sep 6, 2024
Merged

GH-4: Update package name #88

merged 1 commit into from
Sep 6, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 5, 2024

Fix GH-4

This is done by the following command line:

find . -type f -exec sed -i'' -e 's,apache/arrow/go,apache/arrow-go,g' '{}' ';'

Fix apacheGH-4

This is done by the following command line:

    find . -type f -exec sed -i'' -e 's,apache/arrow/go,apache/arrow-go,g' '{}' ';'
@kou kou mentioned this pull request Sep 5, 2024
@kou
Copy link
Member Author

kou commented Sep 5, 2024

I want to prevent adding a new Go commit to apache/arrow after this. Because cherry-picking will be difficult after this.

@kou kou requested review from zeroshade and joellubi September 6, 2024 01:12
@kou
Copy link
Member Author

kou commented Sep 6, 2024

@zeroshade @joellubi Can we proceed with this? This is a blocker of all CI related tasks.

@zeroshade
Copy link
Member

Let's proceed with this so we can keep moving. I'll look at the outstanding Go-related PRs and shift them here afterwards

@kou
Copy link
Member Author

kou commented Sep 6, 2024

Thanks!

@kou kou merged commit 70ac142 into apache:main Sep 6, 2024
@kou kou deleted the update-package-name branch September 6, 2024 22:01
@joellubi
Copy link
Member

joellubi commented Sep 7, 2024

This reminded me that the go package name in the .proto files will need to be updated as well. That also means that codegen will need to get updated so that it can be built with definitions in another repo. I've opened an issue for this: #89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update package name
3 participants