-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kwarg chunksize for default data partitioning for write #400
Open
svilupp
wants to merge
4
commits into
apache:main
Choose a base branch
from
svilupp:add-chunksize-kwarg-for-write
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6497967
add kwarg chunksize for default partitioning
svilupp 2fdf4ba
require rowaccess and avoid Tables.rows (we can lose types in cases c…
svilupp 025cc60
change back to Iterators.partition(Tables.rows(df),chunksize)
svilupp 586887f
add DataFrames compat
svilupp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,14 +48,29 @@ Supported keyword arguments to `Arrow.write` include: | |
* `metadata=Arrow.getmetadata(tbl)`: the metadata that should be written as the table's schema's `custom_metadata` field; must either be `nothing` or an iterable of `<:AbstractString` pairs. | ||
* `ntasks::Int`: number of buffered threaded tasks to allow while writing input partitions out as arrow record batches; default is no limit; for unbuffered writing, pass `ntasks=0` | ||
* `file::Bool=false`: if a an `io` argument is being written to, passing `file=true` will cause the arrow file format to be written instead of just IPC streaming | ||
* `chunksize::Union{Nothing,Integer}=64000`: if a table is being written, this will cause the table to be partitioned into chunks of the given size (`chunksize` rows); if `nothing`, no partitioning will occur | ||
""" | ||
function write end | ||
|
||
write(io_or_file; kw...) = x -> write(io_or_file, x; kw...) | ||
|
||
function write(file_path, tbl; kwargs...) | ||
function write(file_path, tbl; chunksize::Union{Nothing,Integer}=64000, kwargs...) | ||
# rowaccces is a necessary pre-requisite for row-iteration (not sufficient though) | ||
if !isnothing(chunksize) && Tables.istable(tbl) && Tables.rowaccess(tbl) | ||
@assert chunksize >= 0 "chunksize must be >= 0" | ||
if hasmethod(Iterators.partition,(typeof(tbl),)) | ||
tbl_source = Iterators.partition(tbl, chunksize) | ||
# verify that we iterated over rows, not columns | ||
@assert length(tbl_source) == cld(size(tbl)[1], chunksize) "Default partitioning method has failed for the provided table (chunks expected: $(cld(size(tbl)[1], chunksize)), chunks found: $(length(tbl_source))). Please set `chunksize=nothing` to disable chunking" | ||
else | ||
# general fallback | ||
tbl_source = Iterators.partition(Tables.rows(tbl), chunksize) | ||
end | ||
else | ||
tbl_source = tbl | ||
end | ||
open(Writer, file_path; file=true, kwargs...) do writer | ||
write(writer, tbl) | ||
write(writer, tbl_source) | ||
end | ||
file_path | ||
end | ||
|
@@ -278,9 +293,23 @@ function Base.close(writer::Writer) | |
nothing | ||
end | ||
|
||
function write(io::IO, tbl; kwargs...) | ||
function write(io::IO, tbl; chunksize::Union{Nothing,Integer}=64000, kwargs...) | ||
# rowaccces is a necessary pre-requisite for row-iteration (not sufficient though) | ||
if !isnothing(chunksize) && Tables.istable(tbl) && Tables.rowaccess(tbl) | ||
@assert chunksize >= 0 "chunksize must be >= 0" | ||
if hasmethod(Iterators.partition,(typeof(tbl),)) | ||
tbl_source = Iterators.partition(tbl, chunksize) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we use https://docs.julialang.org/en/v1/base/iterators/#Base.Iterators.partition |
||
# verify that we iterated over rows, not columns | ||
@assert length(tbl_source) == cld(size(tbl)[1], chunksize) "Default partitioning method has failed for the provided table (chunks expected: $(cld(size(tbl)[1], chunksize)), chunks found: $(length(tbl_source))). Please set `chunksize=nothing` to disable chunking" | ||
else | ||
# general fallback | ||
tbl_source = Iterators.partition(Tables.rows(tbl), chunksize) | ||
end | ||
else | ||
tbl_source = tbl | ||
end | ||
open(Writer, io; file=false, kwargs...) do writer | ||
write(writer, tbl) | ||
write(writer, tbl_source) | ||
end | ||
io | ||
end | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
chunksize
should move to be a new field inWriter
with default kwarg value set in theBase.open
constructor on L170. This would eliminate the code duplication.